Fix ConvTranspose symmetric non-constant padding #2463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2463 +/- ##
===========================================
+ Coverage 40.98% 73.91% +32.92%
===========================================
Files 32 32
Lines 1886 1928 +42
===========================================
+ Hits 773 1425 +652
+ Misses 1113 503 -610 ☔ View full report in Codecov by Sentry. |
|
looks good. Could you rebase? |
3 tasks
paulnovo
force-pushed
the
convtranspose-symmetric-pad
branch
from
2af2862
to
1dbbf52
Compare
The ConvTranspose was not able to handle symmetric non-constant padding (ie, `pad=(1, 0)` for 2D ConvTranspose). Constant padding (ie `pad=1` for 2D ConvTranspose) and assymetric non-constant padding (ie, `pad=(1, 0, 2, 3)`) worked correctly. This commit fixes symmetric non-constant padding and adds unit tests to ensure it produces the same output size as an equivalent fully expanded padding. Fixes FluxML#2424
paulnovo
force-pushed
the
convtranspose-symmetric-pad
branch
from
1dbbf52
to
597ec6f
Compare
|
@CarloLucibello I believe the AMD test failures on buildkite are also failing on master. I was able to get all AMD tests passing on a branch without the recent removal of enzyme. Can this merge, or should we wait for everything to pass. |
CarloLucibello
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ConvTranspose was not able to handle symmetric non-constant padding (ie,
pad=(1, 0)for 2D ConvTranspose). Constant padding (iepad=1for 2D ConvTranspose) and assymetric non-constant padding (ie,pad=(1, 0, 2, 3)) worked correctly. This commit fixes symmetric non-constant padding and adds unit tests to ensure it produces the same output size as an equivalent fully expanded padding.Fixes #2424
PR Checklist